fix #260 - bug: Start/End node styles reference unavailable Tailwind CSS variables inside Shadow DOM#261
Open
Conversation
Signed-off-by: fantonangeli <fabrizio.antonangeli@gmail.com>
Signed-off-by: fantonangeli <fabrizio.antonangeli@gmail.com>
✅ Deploy Preview for swf-editor ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses styling regressions when @serverlessworkflow/diagram-editor is embedded inside a Shadow DOM host (e.g., via Web Components), where Tailwind “base/preflight” CSS variables (like --tw-border-style) may not be present, causing Start/End nodes to lose expected border styling.
Changes:
- Add explicit
border-solidutilities to Start/End node (and related terminal marker) styles so borders render correctly without relying on Tailwind preflight variables. - Align the affected node styles to use gray palette utilities (gray-*) consistently.
- Add a changeset to publish the fix as a patch release.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/serverless-workflow-diagram-editor/src/react-flow/diagram/Diagram.css | Updates Tailwind @apply rules for terminal + Start/End nodes to explicitly set border-style: solid for Shadow DOM compatibility. |
| .changeset/fix-start-end-nodes-styling.md | Declares a patch release for @serverlessworkflow/diagram-editor documenting the Shadow DOM styling fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fantonangeli
requested review from
cheryl7114,
handreyrc,
kumaradityaraj and
ricardozanini
ricardozanini
approved these changes
Jul 10, 2026
kumaradityaraj
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #260
Describe the Bug
Some Start/End node styles reference CSS variables that are not available when the Diagram Editor is embedded inside a Shadow DOM host using Web Components.
Observed examples include missing Tailwind internal variables such as
--tw-border-style.How to test:
@serverlessworkflow/diagram-editor.dist/styles.cssinside the shadow root.Preview:
Storybook:
Embedding the Diagram Editor through Web Components:
